third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py ('K') | « third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('j') | third_party/WebKit/Source/bindings/scripts/v8_utilities.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 939dda0dda62e1db8eefdff1b4f1db041fc12d17..109a8d3e5758821f1d63457bc0d16c7f7c26a71b 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -111,7 +111,7 @@ CPP_SPECIAL_CONVERSION_RULES = {

'Date': 'double',

'Dictionary': 'Dictionary',

'EventHandler': 'EventListener*',

- 'NodeFilter': 'RefPtrWillBeRawPtr<NodeFilter>',

+ 'NodeFilter': 'RawPtr<NodeFilter>',

'Promise': 'ScriptPromise',

'ScriptValue': 'ScriptValue',

# FIXME: Eliminate custom bindings for XPathNSResolver http://crbug.com/345529

@@ -303,7 +303,7 @@ IdlType.set_garbage_collected_types = classmethod(

cls.garbage_collected_types.update(new_garbage_collected_types))

-# [WillBeGarbageCollected]

+# [GarbageCollected]

IdlType.will_be_garbage_collected_types = set()

sof 2016/02/09 15:45:45 Remove?

IdlType.is_will_be_garbage_collected = property(