third_party/WebKit/Source/core/page/ChromeClient.h - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/page/AutoscrollController.cpp ('k') | third_party/WebKit/Source/core/page/ChromeClientTest.cpp » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index f28f6f53ebd5ed0b1fd9605aef6927bfd4dc8998..06fd31c04c88cad49b69ffaa5c3c3013a9d7afd3 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -161,7 +161,7 @@ public:

virtual void annotatedRegionsChanged() = 0;

- virtual PassOwnPtrWillBeRawPtr<ColorChooser> openColorChooser(LocalFrame*, ColorChooserClient*, const Color&) = 0;

+ virtual RawPtr<ColorChooser> openColorChooser(LocalFrame*, ColorChooserClient*, const Color&) = 0;

// This function is used for:

// - Mandatory date/time choosers if !ENABLE(INPUT_MULTIPLE_FIELDS_UI)

@@ -169,7 +169,7 @@ public:

// returns true, if ENABLE(INPUT_MULTIPLE_FIELDS_UI)

// - <datalist> UI for date/time input types regardless of

// ENABLE(INPUT_MULTIPLE_FIELDS_UI)

- virtual PassRefPtrWillBeRawPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;

+ virtual RawPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;

virtual void openTextDataListChooser(HTMLInputElement&)= 0;

@@ -208,7 +208,7 @@ public:

// Checks if there is an opened popup, called by LayoutMenuList::showPopup().

virtual bool hasOpenedPopup() const = 0;

- virtual PassRefPtrWillBeRawPtr<PopupMenu> openPopupMenu(LocalFrame&, HTMLSelectElement&) = 0;

+ virtual RawPtr<PopupMenu> openPopupMenu(LocalFrame&, HTMLSelectElement&) = 0;

virtual DOMWindow* pagePopupWindowForTesting() const = 0;

virtual void postAccessibilityNotification(AXObject*, AXObjectCache::AXNotification) { }

@@ -231,7 +231,7 @@ public:

virtual bool isChromeClientImpl() const { return false; }

- virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element>>&, LocalFrame*) { }

+ virtual void didAssociateFormControls(const HeapVector<Member<Element>>&, LocalFrame*) { }

virtual void didChangeValueInTextField(HTMLFormControlElement&) { }

virtual void didEndEditingOnTextField(HTMLInputElement&) { }

virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent&) { }