Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index e3513778c8ddb41c7a2a02a99e972b2f9b045353..16241f64a3627fbd1b8bf21c4aaf23461b89a210 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -130,9 +130,9 @@ ChromeClientImpl::~ChromeClientImpl()
{
}
-PassOwnPtrWillBeRawPtr<ChromeClientImpl> ChromeClientImpl::create(WebViewImpl* webView)
+RawPtr<ChromeClientImpl> ChromeClientImpl::create(WebViewImpl* webView)
{
- return adoptPtrWillBeNoop(new ChromeClientImpl(webView));
+ return (new ChromeClientImpl(webView));
}
void* ChromeClientImpl::webView() const
@@ -607,10 +607,10 @@ void ChromeClientImpl::printDelegate(LocalFrame* frame)
m_webView->client()->printPage(WebLocalFrameImpl::fromFrame(frame));
}
-PassOwnPtrWillBeRawPtr<ColorChooser> ChromeClientImpl::openColorChooser(LocalFrame* frame, ColorChooserClient* chooserClient, const Color&)
+RawPtr<ColorChooser> ChromeClientImpl::openColorChooser(LocalFrame* frame, ColorChooserClient* chooserClient, const Color&)
{
notifyPopupOpeningObservers();
- OwnPtrWillBeRawPtr<ColorChooserUIController> controller = nullptr;
+ RawPtr<ColorChooserUIController> controller = nullptr;
if (RuntimeEnabledFeatures::pagePopupEnabled())
controller = ColorChooserPopupUIController::create(frame, this, chooserClient);
else
@@ -619,7 +619,7 @@ PassOwnPtrWillBeRawPtr<ColorChooser> ChromeClientImpl::openColorChooser(LocalFra
return controller.release();
}
-PassRefPtrWillBeRawPtr<DateTimeChooser> ChromeClientImpl::openDateTimeChooser(DateTimeChooserClient* pickerClient, const DateTimeChooserParameters& parameters)
+RawPtr<DateTimeChooser> ChromeClientImpl::openDateTimeChooser(DateTimeChooserClient* pickerClient, const DateTimeChooserParameters& parameters)
{
notifyPopupOpeningObservers();
#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
@@ -831,11 +831,11 @@ bool ChromeClientImpl::hasOpenedPopup() const
return m_webView->hasOpenedPopup();
}
-PassRefPtrWillBeRawPtr<PopupMenu> ChromeClientImpl::openPopupMenu(LocalFrame& frame, HTMLSelectElement& select)
+RawPtr<PopupMenu> ChromeClientImpl::openPopupMenu(LocalFrame& frame, HTMLSelectElement& select)
{
notifyPopupOpeningObservers();
if (WebViewImpl::useExternalPopupMenus())
- return adoptRefWillBeNoop(new ExternalPopupMenu(frame, select, *m_webView));
+ return (new ExternalPopupMenu(frame, select, *m_webView));
ASSERT(RuntimeEnabledFeatures::pagePopupEnabled());
return PopupMenuImpl::create(this, select);
@@ -928,7 +928,7 @@ void ChromeClientImpl::annotatedRegionsChanged()
client->draggableRegionsChanged();
}
-void ChromeClientImpl::didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element>>& elements, LocalFrame* frame)
+void ChromeClientImpl::didAssociateFormControls(const HeapVector<Member<Element>>& elements, LocalFrame* frame)
{
WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
if (webframe->autofillClient())

Powered by Google App Engine
This is Rietveld 408576698