Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/TopControlsTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp
index 5ed7c95296884dff751058108392aaca81f6ffd0..99df11a973381f20231672f185821373fe8ab20a 100644
--- a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp
+++ b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp
@@ -118,9 +118,9 @@ public:
webViewImpl()->handleInputEvent(generateEvent(WebInputEvent::GestureScrollEnd));
}
- PassRefPtrWillBeRawPtr<Element> getElementById(const WebString& id)
+ RawPtr<Element> getElementById(const WebString& id)
{
- return static_cast<PassRefPtrWillBeRawPtr<Element>>(
+ return static_cast<RawPtr<Element>>(
webViewImpl()->mainFrame()->document().getElementById(id));
}
@@ -575,9 +575,9 @@ TEST_F(TopControlsTest, MAYBE(DontAffectLayoutHeight))
// When the top controls are showing, there's 300px for the layout height so
// 50% should result in both the position:fixed and position: absolute divs
// having 150px of height.
- RefPtrWillBeRawPtr<Element> absPos =
+ RawPtr<Element> absPos =
getElementById(WebString::fromUTF8("abs"));
- RefPtrWillBeRawPtr<Element> fixedPos =
+ RawPtr<Element> fixedPos =
getElementById(WebString::fromUTF8("fixed"));
EXPECT_FLOAT_EQ(150.f, absPos->getBoundingClientRect()->height());
EXPECT_FLOAT_EQ(150.f, fixedPos->getBoundingClientRect()->height());
@@ -619,9 +619,9 @@ TEST_F(TopControlsTest, MAYBE(DontAffectVHUnits))
// 'vh' units should be based on the viewport when the top controls are
// hidden.
- RefPtrWillBeRawPtr<Element> absPos =
+ RawPtr<Element> absPos =
getElementById(WebString::fromUTF8("abs"));
- RefPtrWillBeRawPtr<Element> fixedPos =
+ RawPtr<Element> fixedPos =
getElementById(WebString::fromUTF8("fixed"));
EXPECT_FLOAT_EQ(200.f, absPos->getBoundingClientRect()->height());
EXPECT_FLOAT_EQ(200.f, fixedPos->getBoundingClientRect()->height());
@@ -673,9 +673,9 @@ TEST_F(TopControlsTest, MAYBE(DontAffectVHUnitsWithScale))
// we have to account for the minimum page scale factor. Since both boxes
// are 50vh, and layout scale = 0.5, we have a vh viewport of 400 / 0.5 = 800
// so we expect 50vh to be 400px.
- RefPtrWillBeRawPtr<Element> absPos =
+ RawPtr<Element> absPos =
getElementById(WebString::fromUTF8("abs"));
- RefPtrWillBeRawPtr<Element> fixedPos =
+ RawPtr<Element> fixedPos =
getElementById(WebString::fromUTF8("fixed"));
EXPECT_FLOAT_EQ(400.f, absPos->getBoundingClientRect()->height());
EXPECT_FLOAT_EQ(400.f, fixedPos->getBoundingClientRect()->height());

Powered by Google App Engine
This is Rietveld 408576698