third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp - Issue 1686483002: Oilpan: Remove most WillBe types from the code base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.h » ('j') | third_party/WebKit/Source/willbe.pl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

index a539b1915400de85a698fb3ee189e38f5ba7282f..b6074a1419ac88b66c8a873af0d9230c4ef78aa4 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp

@@ -20,7 +20,7 @@ protected:

private:

OwnPtr<DummyPageHolder> m_dummyPageHolder;

- RefPtrWillBePersistent<HTMLDocument> m_document;

+ Persistent<HTMLDocument> m_document;

};

void HTMLSelectElementTest::SetUp()

@@ -128,7 +128,7 @@ TEST_F(HTMLSelectElementTest, ActiveSelectionEndAfterOptionRemoval)

document().documentElement()->setInnerHTML("<select><optgroup><option selected>o1</option></optgroup></select>", ASSERT_NO_EXCEPTION);

document().view()->updateAllLifecyclePhases();

HTMLSelectElement* select = toHTMLSelectElement(document().body()->firstChild());

- RefPtrWillBeRawPtr<HTMLOptionElement> option = toHTMLOptionElement(select->firstChild()->firstChild());

+ RawPtr<HTMLOptionElement> option = toHTMLOptionElement(select->firstChild()->firstChild());

EXPECT_EQ(1, select->activeSelectionEndListIndex());

select->firstChild()->removeChild(option, ASSERT_NO_EXCEPTION);

EXPECT_EQ(-1, select->activeSelectionEndListIndex());