Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 ScrollBehaviorInstant, 56 ScrollBehaviorInstant,
57 ScrollBehaviorSmooth, 57 ScrollBehaviorSmooth,
58 }; 58 };
59 59
60 enum IncludeScrollbarsInRect { 60 enum IncludeScrollbarsInRect {
61 ExcludeScrollbars, 61 ExcludeScrollbars,
62 IncludeScrollbars, 62 IncludeScrollbars,
63 }; 63 };
64 64
65 #if ENABLE(OILPAN) 65 #if ENABLE(OILPAN)
66 // Oilpan: Using the transition type WillBeGarbageCollectedMixin is 66 // Oilpan: Using the transition type GarbageCollectedMixin is
67 // problematic non-Oilpan as the type expands to DummyBase, exporting it 67 // problematic non-Oilpan as the type expands to DummyBase, exporting it
68 // also from 'platform' as a result. Bringing about duplicate DummyBases 68 // also from 'platform' as a result. Bringing about duplicate DummyBases
69 // as core also exports same; with component build linking fails as a 69 // as core also exports same; with component build linking fails as a
70 // result. Hence the workaround of not using a transition type. 70 // result. Hence the workaround of not using a transition type.
71 class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin { 71 class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin {
72 #else 72 #else
73 class PLATFORM_EXPORT ScrollableArea { 73 class PLATFORM_EXPORT ScrollableArea {
74 #endif 74 #endif
75 WTF_MAKE_NONCOPYABLE(ScrollableArea); 75 WTF_MAKE_NONCOPYABLE(ScrollableArea);
76 public: 76 public:
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 void userScrollHelper(const DoublePoint&, ScrollBehavior); 319 void userScrollHelper(const DoublePoint&, ScrollBehavior);
320 320
321 // This function should be overriden by subclasses to perform the actual scr oll of the content. 321 // This function should be overriden by subclasses to perform the actual scr oll of the content.
322 virtual void setScrollOffset(const DoublePoint& offset, ScrollType) = 0; 322 virtual void setScrollOffset(const DoublePoint& offset, ScrollType) = 0;
323 323
324 virtual int lineStep(ScrollbarOrientation) const; 324 virtual int lineStep(ScrollbarOrientation) const;
325 virtual int pageStep(ScrollbarOrientation) const; 325 virtual int pageStep(ScrollbarOrientation) const;
326 virtual int documentStep(ScrollbarOrientation) const; 326 virtual int documentStep(ScrollbarOrientation) const;
327 virtual float pixelStep(ScrollbarOrientation) const; 327 virtual float pixelStep(ScrollbarOrientation) const;
328 328
329 mutable OwnPtrWillBeMember<ScrollAnimatorBase> m_scrollAnimator; 329 mutable Member<ScrollAnimatorBase> m_scrollAnimator;
330 mutable OwnPtrWillBeMember<ProgrammaticScrollAnimator> m_programmaticScrollA nimator; 330 mutable Member<ProgrammaticScrollAnimator> m_programmaticScrollAnimator;
331 331
332 unsigned m_scrollbarOverlayStyle : 2; // ScrollbarOverlayStyle 332 unsigned m_scrollbarOverlayStyle : 2; // ScrollbarOverlayStyle
333 333
334 unsigned m_scrollOriginChanged : 1; 334 unsigned m_scrollOriginChanged : 1;
335 335
336 unsigned m_horizontalScrollbarNeedsPaintInvalidation : 1; 336 unsigned m_horizontalScrollbarNeedsPaintInvalidation : 1;
337 unsigned m_verticalScrollbarNeedsPaintInvalidation : 1; 337 unsigned m_verticalScrollbarNeedsPaintInvalidation : 1;
338 unsigned m_scrollCornerNeedsPaintInvalidation : 1; 338 unsigned m_scrollCornerNeedsPaintInvalidation : 1;
339 339
340 // There are 6 possible combinations of writing mode and direction. Scroll o rigin will be non-zero in the x or y axis 340 // There are 6 possible combinations of writing mode and direction. Scroll o rigin will be non-zero in the x or y axis
341 // if there is any reversed direction or writing-mode. The combinations are: 341 // if there is any reversed direction or writing-mode. The combinations are:
342 // writing-mode / direction scrollOrigin.x() set scrollOrigin.y() set 342 // writing-mode / direction scrollOrigin.x() set scrollOrigin.y() set
343 // horizontal-tb / ltr NO NO 343 // horizontal-tb / ltr NO NO
344 // horizontal-tb / rtl YES NO 344 // horizontal-tb / rtl YES NO
345 // vertical-lr / ltr NO NO 345 // vertical-lr / ltr NO NO
346 // vertical-lr / rtl NO YES 346 // vertical-lr / rtl NO YES
347 // vertical-rl / ltr YES NO 347 // vertical-rl / ltr YES NO
348 // vertical-rl / rtl YES YES 348 // vertical-rl / rtl YES YES
349 IntPoint m_scrollOrigin; 349 IntPoint m_scrollOrigin;
350 }; 350 };
351 351
352 } // namespace blink 352 } // namespace blink
353 353
354 #endif // ScrollableArea_h 354 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698