| OLD | NEW |
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef WebFrameImplBase_h | 5 #ifndef WebFrameImplBase_h |
| 6 #define WebFrameImplBase_h | 6 #define WebFrameImplBase_h |
| 7 | 7 |
| 8 #include "platform/heap/Handle.h" | 8 #include "platform/heap/Handle.h" |
| 9 #include "wtf/text/AtomicString.h" | 9 #include "wtf/text/AtomicString.h" |
| 10 | 10 |
| 11 namespace blink { | 11 namespace blink { |
| 12 | 12 |
| 13 class Frame; | 13 class Frame; |
| 14 class FrameHost; | 14 class FrameHost; |
| 15 class FrameOwner; | 15 class FrameOwner; |
| 16 | 16 |
| 17 // WebFrameImplBase exists to avoid the diamond inheritance problem: | 17 // WebFrameImplBase exists to avoid the diamond inheritance problem: |
| 18 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame. | 18 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame. |
| 19 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl | 19 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl |
| 20 // implements WebRemoteFrame. | 20 // implements WebRemoteFrame. |
| 21 // - The private implementations should share some functionality, but cannot | 21 // - The private implementations should share some functionality, but cannot |
| 22 // inherit from a common base class inheriting WebFrame. This would result in | 22 // inherit from a common base class inheriting WebFrame. This would result in |
| 23 // WebFrame beind inherited from two different base classes. | 23 // WebFrame beind inherited from two different base classes. |
| 24 // | 24 // |
| 25 // To get around this, only the private implementations have WebFrameImplBase as | 25 // To get around this, only the private implementations have WebFrameImplBase as |
| 26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying | 26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying |
| 27 // implementation as an instance of the base class, but has no inheritance | 27 // implementation as an instance of the base class, but has no inheritance |
| 28 // relationship with it. The cost is a virtual indirection, but this is nicer | 28 // relationship with it. The cost is a virtual indirection, but this is nicer |
| 29 // than the previous manual dispatch emulating real virtual dispatch. | 29 // than the previous manual dispatch emulating real virtual dispatch. |
| 30 class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra
meImplBase> { | 30 class WebFrameImplBase : public GarbageCollectedFinalized<WebFrameImplBase> { |
| 31 public: | 31 public: |
| 32 virtual ~WebFrameImplBase(); | 32 virtual ~WebFrameImplBase(); |
| 33 | 33 |
| 34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString
& name, const AtomicString& fallbackName) = 0; | 34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString
& name, const AtomicString& fallbackName) = 0; |
| 35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be
const... | 35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be
const... |
| 36 virtual Frame* frame() const = 0; | 36 virtual Frame* frame() const = 0; |
| 37 | 37 |
| 38 DECLARE_VIRTUAL_TRACE(); | 38 DECLARE_VIRTUAL_TRACE(); |
| 39 }; | 39 }; |
| 40 | 40 |
| 41 } // namespace blink | 41 } // namespace blink |
| 42 | 42 |
| 43 #endif // WebFrameImplBase_h | 43 #endif // WebFrameImplBase_h |
| OLD | NEW |