Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 1686483002: Oilpan: Remove most WillBe types from the code base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 17 matching lines...) Expand all
28 28
29 #include "core/editing/VisibleSelection.h" 29 #include "core/editing/VisibleSelection.h"
30 #include "core/editing/commands/EditAction.h" 30 #include "core/editing/commands/EditAction.h"
31 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class CompositeEditCommand; 35 class CompositeEditCommand;
36 class Document; 36 class Document;
37 37
38 class EditCommand : public RefCountedWillBeGarbageCollectedFinalized<EditCommand > { 38 class EditCommand : public GarbageCollectedFinalized<EditCommand> {
39 public: 39 public:
40 virtual ~EditCommand(); 40 virtual ~EditCommand();
41 41
42 void setParent(CompositeEditCommand*); 42 void setParent(CompositeEditCommand*);
43 43
44 virtual EditAction editingAction() const; 44 virtual EditAction editingAction() const;
45 45
46 const VisibleSelection& startingSelection() const { return m_startingSelecti on; } 46 const VisibleSelection& startingSelection() const { return m_startingSelecti on; }
47 const VisibleSelection& endingSelection() const { return m_endingSelection; } 47 const VisibleSelection& endingSelection() const { return m_endingSelection; }
48 48
(...skipping 13 matching lines...) Expand all
62 void setStartingSelection(const VisibleSelection&); 62 void setStartingSelection(const VisibleSelection&);
63 void setEndingSelection(const VisibleSelection&); 63 void setEndingSelection(const VisibleSelection&);
64 void setEndingSelection(const VisiblePosition&); 64 void setEndingSelection(const VisiblePosition&);
65 65
66 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use 66 // TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
67 // |VisiblePosition::characterAfter()| and 67 // |VisiblePosition::characterAfter()| and
68 // |VisiblePosition::characterBefore()|. 68 // |VisiblePosition::characterBefore()|.
69 static bool isRenderedCharacter(const Position&); 69 static bool isRenderedCharacter(const Position&);
70 70
71 private: 71 private:
72 RefPtrWillBeMember<Document> m_document; 72 Member<Document> m_document;
73 VisibleSelection m_startingSelection; 73 VisibleSelection m_startingSelection;
74 VisibleSelection m_endingSelection; 74 VisibleSelection m_endingSelection;
75 RawPtrWillBeMember<CompositeEditCommand> m_parent; 75 Member<CompositeEditCommand> m_parent;
76 }; 76 };
77 77
78 enum ShouldAssumeContentIsAlwaysEditable { 78 enum ShouldAssumeContentIsAlwaysEditable {
79 AssumeContentIsAlwaysEditable, 79 AssumeContentIsAlwaysEditable,
80 DoNotAssumeContentIsAlwaysEditable, 80 DoNotAssumeContentIsAlwaysEditable,
81 }; 81 };
82 82
83 class SimpleEditCommand : public EditCommand { 83 class SimpleEditCommand : public EditCommand {
84 public: 84 public:
85 virtual void doUnapply() = 0; 85 virtual void doUnapply() = 0;
86 virtual void doReapply(); // calls doApply() 86 virtual void doReapply(); // calls doApply()
87 87
88 protected: 88 protected:
89 explicit SimpleEditCommand(Document& document) : EditCommand(document) { } 89 explicit SimpleEditCommand(Document& document) : EditCommand(document) { }
90 90
91 private: 91 private:
92 bool isSimpleEditCommand() const final { return true; } 92 bool isSimpleEditCommand() const final { return true; }
93 }; 93 };
94 94
95 DEFINE_TYPE_CASTS(SimpleEditCommand, EditCommand, command, command->isSimpleEdit Command(), command.isSimpleEditCommand()); 95 DEFINE_TYPE_CASTS(SimpleEditCommand, EditCommand, command, command->isSimpleEdit Command(), command.isSimpleEditCommand());
96 96
97 } // namespace blink 97 } // namespace blink
98 98
99 #endif // EditCommand_h 99 #endif // EditCommand_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698