Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8046)

Unified Diff: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
diff --git a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
index 4aef871fab5a58f357693c98cc8585d477ad9ce2..f2472335d458384d0b8a445a25ccbdaa6e7ae549 100644
--- a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
+++ b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
@@ -101,19 +101,19 @@ views::View* AutoSigninFirstRunDialogView::GetInitiallyFocusedView() {
return ok_button_;
}
-int AutoSigninFirstRunDialogView::GetDialogButtons() const {
- // None because ESC is equivalent to Cancel. It shouldn't turn off the auto
- // signin.
- return ui::DIALOG_BUTTON_NONE;
-}
-
-void AutoSigninFirstRunDialogView::OnClosed() {
+void AutoSigninFirstRunDialogView::WindowClosing() {
if (controller_)
controller_->OnCloseDialog();
// This method is called twice. crbug.com/583330
vasilii 2016/02/11 10:37:48 Assuming that the method isn't called twice you ca
Evan Stade 2016/02/11 20:02:11 Done.
controller_ = nullptr;
}
+int AutoSigninFirstRunDialogView::GetDialogButtons() const {
+ // None because ESC is equivalent to Cancel. It shouldn't turn off the auto
+ // signin.
+ return ui::DIALOG_BUTTON_NONE;
+}
+
void AutoSigninFirstRunDialogView::ButtonPressed(views::Button* sender,
const ui::Event& event) {
if (sender == ok_button_)

Powered by Google App Engine
This is Rietveld 408576698