Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/browser/ui/views/first_run_dialog.cc

Issue 1686433002: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/first_run_dialog.cc
diff --git a/chrome/browser/ui/views/first_run_dialog.cc b/chrome/browser/ui/views/first_run_dialog.cc
index 32050fe2407a8036ce17b7aeea697a8fbd2b1419..89b12dfbff354a3ebd3d71cb3f675615bc4a0570 100644
--- a/chrome/browser/ui/views/first_run_dialog.cc
+++ b/chrome/browser/ui/views/first_run_dialog.cc
@@ -111,11 +111,6 @@ views::View* FirstRunDialog::CreateExtraView() {
return link;
}
-void FirstRunDialog::OnClosed() {
- first_run::SetShouldShowWelcomePage();
- Done();
-}
-
bool FirstRunDialog::Accept() {
GetWidget()->Hide();
@@ -137,6 +132,11 @@ int FirstRunDialog::GetDialogButtons() const {
return ui::DIALOG_BUTTON_OK;
}
+void FirstRunDialog::WindowClosing() {
+ first_run::SetShouldShowWelcomePage();
+ Done();
+}
+
void FirstRunDialog::LinkClicked(views::Link* source, int event_flags) {
platform_util::OpenExternal(profile_, GURL(chrome::kLearnMoreReportingURL));
}
« no previous file with comments | « chrome/browser/ui/views/first_run_dialog.h ('k') | chrome/browser/ui/views/passwords/account_chooser_dialog_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698