Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 168643003: Add context to "file must be sorted" error message in ios/PRESUBMIT.py (Closed)

Created:
6 years, 10 months ago by Thiemo Nagel
Modified:
6 years, 10 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add context to "file must be sorted" error message in ios/PRESUBMIT.py BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251664

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/ios/PRESUBMIT.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Hi Julian, may I ask you to take a look at this small improvement? (The ...
6 years, 10 months ago (2014-02-15 19:16:35 UTC) #1
pastarmovj
Yes my blessing should suffice. And your changes seems fine to me. LGTM.
6 years, 10 months ago (2014-02-17 08:49:57 UTC) #2
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 10 months ago (2014-02-17 10:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/168643003/40001
6 years, 10 months ago (2014-02-17 10:22:33 UTC) #4
Thiemo Nagel
On 2014/02/17 08:49:57, pastarmovj wrote: > Yes my blessing should suffice. And your changes seems ...
6 years, 10 months ago (2014-02-17 10:22:37 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 12:19:39 UTC) #6
Message was sent while issue was closed.
Change committed as 251664

Powered by Google App Engine
This is Rietveld 408576698