Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168643002: Convert scoped_ptr_malloc -> scoped_ptr, part 1. (Closed)

Created:
6 years, 10 months ago by viettrungluu
Modified:
6 years, 10 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, gavinp+memory_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, fischman+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, Lei Zhang, mcasas+watch_chromium.org, tommycli, Greg Billock, wjia+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Convert scoped_ptr_malloc -> scoped_ptr, part 1. scoped_ptr_malloc is deprecated; let's get rid of it. R=brettw@chromium.org TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -59 lines) Patch
M base/debug/stack_trace_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 2 chunks +12 lines, -10 lines 0 comments Download
M base/file_version_info_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/aligned_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/process/launch_posix.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/process/process_info_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_runner_util_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/app/image_pre_reader_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_win.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 10 months ago (2014-02-15 21:28:08 UTC) #1
brettw
LGTM
6 years, 10 months ago (2014-02-16 05:41:15 UTC) #2
viettrungluu
chrome owners TBR -> thakis
6 years, 10 months ago (2014-02-16 06:29:39 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 10 months ago (2014-02-16 06:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/168643002/1
6 years, 10 months ago (2014-02-16 06:29:52 UTC) #5
Nico
chrome lgtm, but if this has multiple parts please file a tracking bug and reference ...
6 years, 10 months ago (2014-02-16 17:20:48 UTC) #6
commit-bot: I haz the power
Change committed as 251625
6 years, 10 months ago (2014-02-16 22:18:51 UTC) #7
viettrungluu
6 years, 10 months ago (2014-02-17 03:03:34 UTC) #8
Message was sent while issue was closed. 
On 2014/02/16 17:20:48, Nico (away Feb 11 - Feb 17) wrote:
> chrome lgtm, but if this has multiple parts please file a tracking bug and
> reference it in all parts.

Thanks. I filed crbug.com/344245, but this was landed by commit-bot first. Oops!

Powered by Google App Engine
This is Rietveld 408576698