Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1686413002: [heap] Cleanup MemoryChunk's declarations (Closed)

Created:
4 years, 10 months ago by Michael Lippautz
Modified:
4 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup MemoryChunk's declarations - Remove unused methods that we should never actually use like SetArea() or set_size(). - Live bytes are now reported with --trace-live-bytes and not gc-verbose. BUG=chromium:581076 LOG=N Committed: https://crrev.com/ffcff3a0f2145fc4893f18a05b9466e3459353ff Cr-Commit-Position: refs/heads/master@{#33908}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -173 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 9 chunks +110 lines, -154 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +30 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Michael Lippautz
PTAL. No changes in semantics. Just removed unused (and unsupported) API calls and clustered related ...
4 years, 10 months ago (2016-02-11 10:26:33 UTC) #11
ulan
lgtm
4 years, 10 months ago (2016-02-11 15:31:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686413002/80001
4 years, 10 months ago (2016-02-11 15:36:13 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 16:31:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686413002/80001
4 years, 10 months ago (2016-02-11 16:33:24 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 10 months ago (2016-02-11 16:39:06 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 16:39:32 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffcff3a0f2145fc4893f18a05b9466e3459353ff
Cr-Commit-Position: refs/heads/master@{#33908}

Powered by Google App Engine
This is Rietveld 408576698