Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2852)

Unified Diff: build_overrides/README.md

Issue 1686373002: Allow WebRTC to require Mac 10.7 deployments in GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Significantly re-work approach based on conversation w/ brettw@ Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/mac_sdk.gni ('k') | build_overrides/build.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/README.md
diff --git a/build_overrides/README.md b/build_overrides/README.md
index d26312c9325ddcc3126ade50802a6cf879454cb1..fa12384341401402bc43a17171b52797fa1f3f0f 100644
--- a/build_overrides/README.md
+++ b/build_overrides/README.md
@@ -18,3 +18,12 @@ create its own build_overrides/v8.gni file, and in it set
The two files should define the same set of variables, but the values can
vary as appropriate to the needs of the two different builds.
+
+The build.gni file provides a way for projects to override defaults for
+variables used in //build itself (which we want to be shareable between
+projects).
+
+TODO(crbug.com/588513): Ideally //build_overrides and, in particular,
+//build_overrides.gni should go away completely in favor of some mechanism
kjellander_chromium 2016/02/22 04:18:40 I guess you mean //build_overrides/build.gni here?
Dirk Pranke 2016/02/22 04:25:04 Good catch, I meant //build_overrides/build.gni o
+that can re-use other required files like //.gn, so that we don't have
+to keep requiring projects to create a bunch of different files to use GN.
« no previous file with comments | « build/config/mac/mac_sdk.gni ('k') | build_overrides/build.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698