services/media/framework/conversion_pipeline_builder.h - Issue 1686363002: Motown: ffmpeg implementations of framework 'parts'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/framework/conversion_pipeline_builder.h

Issue 1686363002: Motown: ffmpeg implementations of framework 'parts' (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Retype some const unique_ptr<T>& parameters to const T&. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/media/framework/conversion_pipeline_builder.h

diff --git a/services/media/framework/conversion_pipeline_builder.h b/services/media/framework/conversion_pipeline_builder.h

index 6957abcef67298a00cc26a4d9e0cfeb44cf71512..9f82f932186866c3b5d025c63f61ffe69a8bd775 100644

--- a/services/media/framework/conversion_pipeline_builder.h

+++ b/services/media/framework/conversion_pipeline_builder.h

@@ -17,9 +17,8 @@ namespace media {

// *output and delivers the resulting output type via *out_type. If it fails,

// returns false, sets *out_type to nullptr and leaves *output unchanged.

bool BuildConversionPipeline(

- const std::unique_ptr<StreamType>& in_type,

- const std::unique_ptr<std::vector<std::unique_ptr<StreamTypeSet>>>&

- out_type_sets,

+ const StreamType& in_type,

+ const std::vector<std::unique_ptr<StreamTypeSet>>& out_type_sets,

Graph* graph,

OutputRef* output,

std::unique_ptr<StreamType>* out_type);