Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1686363002: Motown: ffmpeg implementations of framework 'parts' (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Retype some const unique_ptr<T>& parameters to const T&. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/util/LASTCHANGE » ('j') | services/media/framework_ffmpeg/ffmpeg_audio_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 45c8e34c084a48396934b2482808c58f90af18fd..55398af430267aa755b2561a486b6bc6af9d6024 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -849,6 +849,9 @@ if (is_clang) {
# TODO(smklein): Consider enabling this once not broken by third party
"-Wno-bitfield-width",
+
+ # TODO(dalesat): Remove once not broken by third party (ffmpeg).
+ "-Wno-constant-conversion",
johngro 2016/03/01 01:31:38 Is it possible to stuff this in the build rules fo
jamesr 2016/03/01 17:56:43 Don't disable warnings like this globally. You ca
dalesat 2016/03/01 20:43:01 FWIW, I'm restoring a flag that was only recently
]
}
}
« no previous file with comments | « no previous file | build/util/LASTCHANGE » ('j') | services/media/framework_ffmpeg/ffmpeg_audio_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698