Motown: ffmpeg implementations of framework 'parts'

services/media/framework_ffmpeg/ffmpeg_io.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_MEDIA_FRAMEWORK_FFMPEG_FFMPEG_IO_H_
+#define SERVICES_MEDIA_FRAMEWORK_FFMPEG_FFMPEG_IO_H_
+
+#include "services/media/framework/parts/reader.h"
+extern "C" {
+#include "third_party/ffmpeg/libavformat/avio.h"
+}
+
+namespace mojo {
+namespace media {
+
+// Creates an ffmpeg avio_context for a given reader.
+AVIOContext* CreateAvioContext(Reader* reader);

[johngro, 2016/03/01 01:31:39]

see earlier comment about raw FFmpeg pointers.  Consider wrapping all of this
stuff (creation/destruction) up in a unique_ptr type which is defined here and
disallowing anything but this code from ever accessing the FFmpeg create/destroy
functions.

[dalesat, 2016/03/01 20:43:02]

Done.

+
+// Frees an avio_context created by CreateContext.
+void FreeAvioContext(AVIOContext*);
+
+}  // namespace media
+}  // namespace mojo
+
+#endif // SERVICES_MEDIA_FRAMEWORK_FFMPEG_FFMPEG_IO_H_