Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: cc/output/begin_frame_args.h

Issue 16863005: cc: Add BeginFrameArgs (Closed) Base URL: http://git.chromium.org/chromium/src.git@nofrc12
Patch Set: Fix android compile Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/begin_frame_args.h
diff --git a/cc/output/begin_frame_args.h b/cc/output/begin_frame_args.h
new file mode 100644
index 0000000000000000000000000000000000000000..291f082d260224136205fd8fd0341958ac751125
--- /dev/null
+++ b/cc/output/begin_frame_args.h
@@ -0,0 +1,62 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_OUTPUT_BEGIN_FRAME_H_
+#define CC_OUTPUT_BEGIN_FRAME_H_
+
+#include "base/time.h"
+#include "cc/base/cc_export.h"
+#include "ipc/ipc_param_traits.h"
piman 2013/06/14 22:53:46 nit: layering violation, cc doesn't depend on IPC
brianderson 2013/06/14 23:32:12 Will fix.
+
+namespace cc {
+
+class CC_EXPORT BeginFrameArgs {
+ public:
+ // Creates an invalid set of values.
+ BeginFrameArgs();
+
+ // You should be able to find all instances where a BeginFrame has been
+ // created by searching for "BeginFrame::Create".
+ static BeginFrameArgs Create(base::TimeTicks frame_time,
+ base::TimeTicks deadline,
+ base::TimeDelta interval);
+ static BeginFrameArgs CreateForSynchronousCompositor();
+ static BeginFrameArgs CreateForTesting();
+
+ // This is the default delta that will be used to adjust the deadline when
+ // proper draw-time estimations are not yet available.
+ static base::TimeDelta DefaultDeadlineAdjustment();
+ static base::TimeDelta DefaultInterval();
+
+ base::TimeTicks frame_time() const {
+ return frame_time_;
+ }
+
+ base::TimeTicks deadline() const {
+ return deadline_;
+ }
+
+ base::TimeDelta interval() const {
+ return interval_;
+ }
+
+ bool IsInvalid() const {
+ return interval_ < base::TimeDelta();
+ }
+
+ private:
+ friend struct IPC::ParamTraits<BeginFrameArgs>;
piman 2013/06/14 22:53:46 nit: you just want this to be a struct. You have h
brianderson 2013/06/14 23:32:12 Ok, I'll just make it a struct with public members
+
+ BeginFrameArgs(base::TimeTicks frame_time,
+ base::TimeTicks deadline,
+ base::TimeDelta interval);
+
+ base::TimeTicks frame_time_;
+ base::TimeTicks deadline_;
+ base::TimeDelta interval_;
+};
+
+} // namespace cc
+
+#endif // CC_OUTPUT_BEGIN_FRAME_H_
« no previous file with comments | « cc/cc.gyp ('k') | cc/output/begin_frame_args.cc » ('j') | cc/output/begin_frame_args.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698