Ensure that element handles never refer to Member objects.

Ensure that element handles never refer to Member objects.

This is necessary in order for "is" checks (e.g. `element is
ConstructorMember`) to function properly in the presence of element
handles.

To make this possible, it was necessary to lazify the `type` getter in
ExecutableMember, so that attempting to wrap an element handle inside
an ExecutableMember doesn't force the actual element to be
resynthesized.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b18cdd3f77f7118791096d57ae8305120bcbe629

[Paul Berry, 2016-02-10 21:34:11]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-10 21:53:27]

LGTM

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:140: [FunctionType type])
[FunctionType this._type] maybe?
OTOH this is not the most nice name to expose to clients.

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1921: _ReferenceInfo info,
List<EntityRef> typeArgumentRefs) {
Do we need "typeArgumentRefs" here now?
Shoudl we document 'classType'?

[Paul Berry, 2016-02-10 22:10:59]

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:140: [FunctionType type])
On 2016/02/10 21:53:26, scheglov wrote:
> [FunctionType this._type] maybe?
> OTOH this is not the most nice name to expose to clients.

Yeah, I had a similar thought.  I think I'd prefer to leave as is so that the
documentation can still refer to [type].

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1686283002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1921: _ReferenceInfo info,
List<EntityRef> typeArgumentRefs) {
On 2016/02/10 21:53:26, scheglov wrote:
> Do we need "typeArgumentRefs" here now?
> Shoudl we document 'classType'?

You're right--we don't need it anymore.  I've removed it and updated the
documentation to refer to [classType] and [info].

[Paul Berry, 2016-02-10 22:11:20]

Description was changed from

==========
Ensure that element handles never refer to Member objects.

This is necessary in order for "is" checks (e.g. `element is
ConstructorMember`) to function properly in the presence of element
handles.

To make this possible, it was necessary to lazify the `type` getter in
ExecutableMember, so that attempting to wrap an element handle inside
an ExecutableMember doesn't force the actual element to be
resynthesized.
==========

to

==========
Ensure that element handles never refer to Member objects.

This is necessary in order for "is" checks (e.g. `element is
ConstructorMember`) to function properly in the presence of element
handles.

To make this possible, it was necessary to lazify the `type` getter in
ExecutableMember, so that attempting to wrap an element handle inside
an ExecutableMember doesn't force the actual element to be
resynthesized.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b18cdd3f77f7118791096d57ae8305120bcbe629
==========

[Paul Berry, 2016-02-10 22:11:22]

Committed patchset #1 (id:1) manually as
b18cdd3f77f7118791096d57ae8305120bcbe629 (presubmit successful).