Skia Filter Quality and Scaling Metrics

include/core/SkDevice.h

 /*
  * Copyright 2010 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkDevice_DEFINED
 #define SkDevice_DEFINED
 
@@ skipping 358 matching lines @@
      *  a device that it knows how to draw, and that it knows how to identify if it is not of the
      *  same subclass (since drawDevice is passed a SkBaseDevice*). If the subclass cannot fulfill
      *  that contract (e.g. PDF cannot support some settings on the paint) it should return NULL,
      *  and the caller may then decide to explicitly create a bitmapdevice, knowing that later
      *  it could not call drawDevice with it (but it could call drawSprite or drawBitmap).
      */
     virtual SkBaseDevice* onCreateDevice(const CreateInfo&, const SkPaint*) {
         return NULL;
     }
 
+    // A helper function used by derived classes to log the scale factor of a bitmap or image draw.
+    void logDrawScaleFactor(const SkMatrix&, SkFilterQuality) const;

[bsalomon, 2016/02/16 14:52:42]

Maybe this should just be a static helper in SkGpuDevice.cpp since no other
subclass is using it (and it's only used in a couple targeted draw calls).

[ericrk, 2016/02/16 22:05:33]

I'm using this in SkBitmapDevice as well - happy to refactor though if you have
something in mind.

[bsalomon, 2016/02/24 18:24:59]

Gotcha.. didn't catch that. Need it be a class member or can it be static?

[ericrk, 2016/02/25 00:22:10]

made it static, good point.

+
 private:
     friend class SkCanvas;
     friend struct DeviceCM; //for setMatrixClip
     friend class SkDraw;
     friend class SkDrawIter;
     friend class SkDeviceFilteredPaint;
     friend class SkImageFilter::DeviceProxy;
     friend class SkNoPixelsBitmapDevice;
     friend class SkSurface_Raster;
 
@@ skipping 24 matching lines @@
     SkSurfaceProps fSurfaceProps;
 
 #ifdef SK_DEBUG
     bool        fAttachedToCanvas;
 #endif
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif