Issue 16862003: Fix the typo in the previous CL for uClibc support in ICU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16862003: Fix the typo in the previous CL for uClibc support in ICU

Created:
7 years, 6 months ago by jungshik at Google

Modified:
7 years, 5 months ago

Reviewers:
Mostyn Bramley-Moore

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

Fix the typo in the previous CL for uClibc support in ICU patch by Mostyn Bramley-Moore TBR=cpu BUG=NONE TEST=ICU build works fine on Linux/CrOS after DEPS change.

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	public/common/unicode/plinux.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

On 2013/06/13 07:34:13, Mostyn Bramley-Moore wrote: > I'm not a reviewer of course, but lgtm. ...

7 years, 5 months ago (2013-07-09 20:15:13 UTC) #2

jungshik at Google

7 years, 5 months ago (2013-07-09 20:15:48 UTC) #3

On 2013/07/09 20:15:13, Jungshik Shin wrote:
> On 2013/06/13 07:34:13, Mostyn Bramley-Moore wrote:
> > I'm not a reviewer of course, but lgtm.
> 
> For the future reference,  this was fixed in the upstream (the upstream takes
a
> different approach to platform dependency handling). See
> ugs.icu-project.org/trac/ticket/9605

http://bugs.icu-project.org/trac/ticket/9605

Expand Messages | Collapse Messages