src/factory.cc - Issue 1686193003: Force SharedFunctionInfo::name() to be a flat string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1686193003: Force SharedFunctionInfo::name() to be a flat string (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 1a3a007a8536c7b3188affcca5c6fb115c60998a..737530f0368e8449e67f9df2bee4746b1d4194ed 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2116,6 +2116,7 @@ Handle<SharedFunctionInfo> Factory::NewSharedFunctionInfo(

Handle<SharedFunctionInfo> share = New<SharedFunctionInfo>(map, OLD_SPACE);

// Set pointer fields.

+ name = String::Flatten(name, TENURED);

share->set_name(*name);

Handle<Code> code;

if (!maybe_code.ToHandle(&code)) {

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-4659.js » ('j') | no next file with comments »