Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1686193003: Force SharedFunctionInfo::name() to be a flat string (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Force SharedFunctionInfo::name() to be a flat string This fact is depended upon by, at least, Parser::ParseLazy, and quite likely by other code. There was already code in %FunctionSetName enforcing this invariant. This patch adds similar code to Factory::NewSharedFunctionInfo(). BUG=v8:4659 LOG=n Committed: https://crrev.com/58a9bc5b5346eed84e55361dd2557074f6108a5c Cr-Commit-Position: refs/heads/master@{#33914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-4659.js View 1 chunk +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
adamk
4 years, 10 months ago (2016-02-10 20:18:10 UTC) #2
rossberg
lgtm
4 years, 10 months ago (2016-02-11 07:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686193003/1
4 years, 10 months ago (2016-02-11 18:51:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 18:52:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 18:53:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58a9bc5b5346eed84e55361dd2557074f6108a5c
Cr-Commit-Position: refs/heads/master@{#33914}

Powered by Google App Engine
This is Rietveld 408576698