Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 1686183003: Use SharedFunctionInfo rather than the JSFunction in the deoptimizer (first step). (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use SharedFunctionInfo rather than the JSFunction in the deoptimizer (first step). This removes uses of JSFunction by the (proper) deoptimizer. This will be useful when we escape analyze JSFunction away. Unfortunately, the debugger still needs JSFunction, so escape analysis would not work yet. Committed: https://crrev.com/9dd5fe296bbce2ebd49d61389f5d02e4b1e0d005 Cr-Commit-Position: refs/heads/master@{#33891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -55 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/deoptimizer.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/deoptimizer.cc View 10 chunks +31 lines, -31 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-11 10:50:17 UTC) #2
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-11 10:52:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686183003/1
4 years, 10 months ago (2016-02-11 11:26:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 12:03:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 12:03:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 12:04:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dd5fe296bbce2ebd49d61389f5d02e4b1e0d005
Cr-Commit-Position: refs/heads/master@{#33891}

Powered by Google App Engine
This is Rietveld 408576698