Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: pkg/analyzer/lib/src/generated/parser.dart

Issue 1686173002: fix #25739, incorrectly expanding a generic comment multiple times (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/token.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/parser.dart
diff --git a/pkg/analyzer/lib/src/generated/parser.dart b/pkg/analyzer/lib/src/generated/parser.dart
index 3aaa54f0d37b33be2e2db31cedde8210652bd752..805ad6e584263b3fabd4651e688a04d69c49ced5 100644
--- a/pkg/analyzer/lib/src/generated/parser.dart
+++ b/pkg/analyzer/lib/src/generated/parser.dart
@@ -3951,6 +3951,8 @@ class Parser {
String comment = t.lexeme.substring(prefixLen, t.lexeme.length - 2);
Token list = _scanGenericMethodComment(comment, t.offset + prefixLen);
if (list != null) {
+ // Remove the tokens from the comment stream.
Bob Nystrom 2016/02/18 16:58:58 Nit: "tokens" -> "token". The overall effect of t
+ t.remove();
// Insert the tokens into the stream.
_injectTokenList(list);
return true;
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/token.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698