Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 1686153003: Adds calls to NativeWidgetFactory (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tfarina, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds calls to NativeWidgetFactory These two places may create native_widgets. We want to route to the factory first, else the wrong thing can happen. BUG=581198 TEST=none R=ben@chromium.org Committed: https://crrev.com/7fa479af1714b5bebf300b58c03544d42dd03d0c Cr-Commit-Position: refs/heads/master@{#374719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
4 years, 10 months ago (2016-02-10 19:06:37 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 10 months ago (2016-02-10 19:24:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686153003/1
4 years, 10 months ago (2016-02-10 20:01:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 21:09:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fa479af1714b5bebf300b58c03544d42dd03d0c
Cr-Commit-Position: refs/heads/master@{#374719}

Powered by Google App Engine
This is Rietveld 408576698