Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: content/renderer/media/media_stream_video_renderer_sink.cc

Issue 1686123004: Post GpuMemoryBufferVideoFramePool deletion on media thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_video_renderer_sink.cc
diff --git a/content/renderer/media/media_stream_video_renderer_sink.cc b/content/renderer/media/media_stream_video_renderer_sink.cc
index 709f9d51d8f11139c35d11b2eb15235c36a52848..ade92b326b3f1822a422a3c726d65db777b23a80 100644
--- a/content/renderer/media/media_stream_video_renderer_sink.cc
+++ b/content/renderer/media/media_stream_video_renderer_sink.cc
@@ -40,6 +40,10 @@ MediaStreamVideoRendererSink::MediaStreamVideoRendererSink(
}
MediaStreamVideoRendererSink::~MediaStreamVideoRendererSink() {
+ if (gpu_memory_buffer_pool_) {
+ media_task_runner_->DeleteSoon(FROM_HERE,
+ gpu_memory_buffer_pool_.release());
+ }
}
void MediaStreamVideoRendererSink::Start() {
@@ -109,6 +113,9 @@ void MediaStreamVideoRendererSink::OnVideoFrame(
return;
}
+ // |gpu_memory_buffer_pool_| would be deleted on |media_task_runner_| in dtor,
Daniele Castagna 2016/02/10 21:33:46 Maybe something like |gpu_memory_buffer_pool_| del
emircan 2016/02/10 23:04:55 Done.
+ // so we know that |gpu_memory_buffer_pool_| is alive when this task is
+ // posted and base::Unretained() usage should be fine.
media_task_runner_->PostTask(
FROM_HERE,
base::Bind(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698