Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1686123002: Revert of Implement symbol @@hasInstance for ES6 instanceof support. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement symbol @@hasInstance for ES6 instanceof support. (patchset #2 id:20001 of https://codereview.chromium.org/1683043003/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/1382/ Original issue's description: > Implement symbol @@hasInstance for ES6 instanceof support. > > BUG= > > Committed: https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 > Cr-Commit-Position: refs/heads/master@{#33870} TBR=bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/99a58d30d25e33fdd39d5e04767a7fd2a3ab184c Cr-Commit-Position: refs/heads/master@{#33871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -73 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M src/heap-symbols.h View 2 chunks +1 line, -1 line 0 comments Download
M src/js/symbol.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/es6/hasinstance-symbol.js View 1 chunk +0 lines, -12 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Implement symbol @@hasInstance for ES6 instanceof support.
4 years, 10 months ago (2016-02-10 16:21:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686123002/1
4 years, 10 months ago (2016-02-10 16:21:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 16:21:39 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:22:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99a58d30d25e33fdd39d5e04767a7fd2a3ab184c
Cr-Commit-Position: refs/heads/master@{#33871}

Powered by Google App Engine
This is Rietveld 408576698