Issue 16861003: MIPS: Fix for bug 245480. Calling new Array(a) with a single argument could result in creating a ho…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16861003: MIPS: Fix for bug 245480. Calling new Array(a) with a single argument could result in creating a ho… (Closed)

Created:
7 years, 6 months ago by palfia

Modified:
7 years, 6 months ago

Reviewers:
kisg, Paul Lind, mvstanton, kilvadyb, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix for bug 245480. Calling new Array(a) with a single argument could result in creating a holey array with a packed elements kind. Port r15095 (4a97e1e4) BUG= Committed: https://code.google.com/p/v8/source/detail?r=15104

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, but please fix the nit. https://codereview.chromium.org/16861003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/16861003/diff/1/src/mips/lithium-codegen-mips.cc#newcode3911 src/mips/lithium-codegen-mips.cc:3911: // look at ...

7 years, 6 months ago (2013-06-12 23:27:30 UTC) #2

palfia

Fixed nits. https://codereview.chromium.org/16861003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/16861003/diff/1/src/mips/lithium-codegen-mips.cc#newcode3911 src/mips/lithium-codegen-mips.cc:3911: // look at the first argument On ...

7 years, 6 months ago (2013-06-12 23:37:09 UTC) #3

Message was sent while issue was closed.

Committed manually as r15104 (presubmit successful).

Expand Messages | Collapse Messages