Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD.gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index aa2a7921e9f816a39687f189d6224738ca3c9e7d..0d4028afc664efa22a66aeca4aa1926a9bff51ef 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -181,6 +181,16 @@ class PasswordFormManager : public PasswordStoreConsumer {
has_generated_password_ = generated_password;
}
+ bool is_manual_generation() { return is_manual_generation_; }
+ void set_is_manual_generation(bool is_manual_generation) {
+ is_manual_generation_ = is_manual_generation;
+ }
+
+ const base::string16& generation_element() { return generation_element_; }
+ void set_generation_element(const base::string16& generation_element) {
+ generation_element_ = generation_element;
+ }
+
bool password_overridden() const { return password_overridden_; }
bool retry_password_form_password_update() const {
@@ -399,6 +409,12 @@ class PasswordFormManager : public PasswordStoreConsumer {
bool UploadChangePasswordForm(const autofill::ServerFieldType& password_type,
const std::string& login_form_signature);
+ // Try to label a password field that was used for generation with information
+ // that the password was generated and upload |form_data|. For labelling
+ // |generation_element_| and |is_manual_generation_| fields are used. Returns
+ // true on success.
+ bool UploadGeneratedVote();
+
// Create pending credentials from provisionally saved form and forms received
// from password store.
void CreatePendingCredentials();
@@ -472,14 +488,20 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Whether this form has an auto generated password.
bool has_generated_password_;
+ // Whether password generation was manually triggered.
+ bool is_manual_generation_;
+
+ // A password field name that is used for generation.
+ base::string16 generation_element_;
+
// Whether the saved password was overridden.
bool password_overridden_;
// A form is considered to be "retry" password if it has only one field which
// is a current password field.
// This variable is true if the password passed through ProvisionallySave() is
- // a password that is not equal to any password from stored for this origin
- // credentials and it was entered on a retry password form.
+ // a password that is not part of any password form stored for this origin
+ // and it was entered on a retry password form.
bool retry_password_form_password_update_;
// Whether the user can choose to generate a password for this form.
« no previous file with comments | « components/password_manager/core/browser/BUILD.gn ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698