Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: components/autofill/core/browser/form_structure_unittest.cc

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD.gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure_unittest.cc
diff --git a/components/autofill/core/browser/form_structure_unittest.cc b/components/autofill/core/browser/form_structure_unittest.cc
index 045f28b5cdcd9bca757b7bb24f5032fd29464f0d..b9b9a49ba14b8c1dbc764371de6720350fd8f4e4 100644
--- a/components/autofill/core/browser/form_structure_unittest.cc
+++ b/components/autofill/core/browser/form_structure_unittest.cc
@@ -2144,8 +2144,13 @@ TEST_F(FormStructureTest,
form_structure.reset(new FormStructure(form));
ASSERT_EQ(form_structure->field_count(), possible_field_types.size());
- for (size_t i = 0; i < form_structure->field_count(); ++i)
+ for (size_t i = 0; i < form_structure->field_count(); ++i) {
form_structure->field(i)->set_possible_types(possible_field_types[i]);
+ if (form_structure->field(i)->name == ASCIIToUTF16("password"))
+ form_structure->field(i)->set_generation_type(
+ autofill::AutofillUploadContents::Field::
+ MANUALLY_TRIGGERED_GENERATION_ON_SIGN_UP_FORM);
+ }
ServerFieldTypeSet available_field_types;
available_field_types.insert(NAME_FIRST);
@@ -2172,8 +2177,12 @@ TEST_F(FormStructureTest,
"Email", "email", 9U);
test::FillUploadField(upload.add_field(), 239111655U, "username", "text",
"username", "email", 86U);
- test::FillUploadField(upload.add_field(), 2051817934U, "password", "password",
- "password", "email", 76U);
+ auto* upload_password_field = upload.add_field();
+ test::FillUploadField(upload_password_field, 2051817934U, "password",
+ "password", "password", "email", 76U);
+ upload_password_field->set_generation_type(
+ autofill::AutofillUploadContents::Field::
+ MANUALLY_TRIGGERED_GENERATION_ON_SIGN_UP_FORM);
std::string expected_upload_string;
ASSERT_TRUE(upload.SerializeToString(&expected_upload_string));
« no previous file with comments | « components/autofill/core/browser/form_structure.cc ('k') | components/autofill/core/browser/proto/server.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698