Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix BUILD.gn Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.h
diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h
index b9c7f3c3f40b6b7462fff6be1f714641b550ea39..e2a239f51c6714239134fc28a02198498d252563 100644
--- a/components/autofill/content/renderer/password_generation_agent.h
+++ b/components/autofill/content/renderer/password_generation_agent.h
@@ -104,7 +104,7 @@ class PasswordGenerationAgent : public content::RenderFrameObserver {
// Sets |generation_element_| to the focused password field and shows a
// generation popup at this field.
- void OnGeneratePassword();
+ void OnUserTriggeredGeneratePassword();
// Stores forms that are candidates for account creation.
AccountCreationFormDataList possible_account_creation_forms_;
@@ -129,6 +129,9 @@ class PasswordGenerationAgent : public content::RenderFrameObserver {
// password.
bool password_is_generated_;
+ // True if password generation was manually triggered.
+ bool is_manually_triggered_;
+
// True if a password was generated and the user edited it. Used for UMA
// stats.
bool password_edited_;

Powered by Google App Engine
This is Rietveld 408576698