Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewers comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.cc
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index 9485e35fc35e57e36701acd6d04247cd9eb0d2bb..a2ebb34ef872750264f7584a383230661ac77058 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -1106,6 +1106,12 @@ void FormStructure::EncodeFormForUpload(AutofillUploadContents* upload) const {
AutofillUploadContents::Field* added_field = upload->add_field();
added_field->set_autofill_type(field_type);
+ if (field->generation_type())
+ added_field->set_generation_type(
+ static_cast<
+ ::autofill::
+ AutofillUploadContents_Field_PasswordGenerationType>(
+ field->generation_type()));
dvadym 2016/02/19 16:25:06 Mathieu@: is it correct way to use proto enums?
Mathieu 2016/02/22 13:25:20 if |generation_type| is of type AutofillUploadCont
dvadym 2016/02/22 14:52:32 Done.
unsigned sig = 0;
// The signature is a required field. If it can't be parsed, the proto

Powered by Google App Engine
This is Rietveld 408576698