Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1686063004: Sending generated vote on password generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // in the screens coordinate system. 120 // in the screens coordinate system.
121 gfx::RectF GetBoundsInScreenSpace(const gfx::RectF& bounds); 121 gfx::RectF GetBoundsInScreenSpace(const gfx::RectF& bounds);
122 122
123 // Checks if the current page fulfils the conditions for the password manager 123 // Checks if the current page fulfils the conditions for the password manager
124 // to be active on it, for example Sync credentials are not saved or auto 124 // to be active on it, for example Sync credentials are not saved or auto
125 // filled. 125 // filled.
126 bool IsPasswordManagementEnabledForCurrentPage() const; 126 bool IsPasswordManagementEnabledForCurrentPage() const;
127 127
128 // Causes the password generation UI to be shown for the specified form. 128 // Causes the password generation UI to be shown for the specified form.
129 // The popup will be anchored at |element_bounds|. The generated password 129 // The popup will be anchored at |element_bounds|. The generated password
130 // will be no longer than |max_length|. 130 // will be no longer than |max_length|.
vabr (Chromium) 2016/02/17 13:43:22 nit: Please explain the added arguments in the com
dvadym 2016/02/19 16:25:05 I've added // |generation_element| should contain
131 void ShowPasswordGenerationPopup(content::RenderFrameHost* render_frame_host, 131 void ShowPasswordGenerationPopup(content::RenderFrameHost* render_frame_host,
132 const gfx::RectF& bounds, 132 const gfx::RectF& bounds,
133 int max_length, 133 int max_length,
134 const base::string16& generation_element,
135 bool is_manually_triggered,
134 const autofill::PasswordForm& form); 136 const autofill::PasswordForm& form);
135 137
136 // Causes the password editing UI to be shown anchored at |element_bounds|. 138 // Causes the password editing UI to be shown anchored at |element_bounds|.
137 void ShowPasswordEditingPopup(content::RenderFrameHost* render_frame_host, 139 void ShowPasswordEditingPopup(content::RenderFrameHost* render_frame_host,
138 const gfx::RectF& bounds, 140 const gfx::RectF& bounds,
139 const autofill::PasswordForm& form); 141 const autofill::PasswordForm& form);
140 142
141 // Shows the dialog where the user can accept or decline the global autosignin 143 // Shows the dialog where the user can accept or decline the global autosignin
142 // setting as a first run experience. The dialog won't appear in Incognito or 144 // setting as a first run experience. The dialog won't appear in Incognito or
143 // when the autosign-in is off. 145 // when the autosign-in is off.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 scoped_ptr<password_manager::LogManager> log_manager_; 179 scoped_ptr<password_manager::LogManager> log_manager_;
178 180
179 // Set during 'NotifyUserAutoSigninBlockedOnFirstRun' in order to store the 181 // Set during 'NotifyUserAutoSigninBlockedOnFirstRun' in order to store the
180 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'. 182 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
181 scoped_ptr<autofill::PasswordForm> form_blocked_on_first_run_; 183 scoped_ptr<autofill::PasswordForm> form_blocked_on_first_run_;
182 184
183 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 185 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
184 }; 186 };
185 187
186 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 188 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698