Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1686033002: Add V8TypeOf<> for IDL dictionaries (Closed)

Created:
4 years, 10 months ago by bashi
Modified:
4 years, 10 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add V8TypeOf<> for IDL dictionaries It is useful when we write a template function/class which takes a IDL dictionary as a template parameter. We can avoid passing both T and V8T. Committed: https://crrev.com/f0d33b6ebbdb33faf292e1e904064476f7f92b06 Cr-Commit-Position: refs/heads/master@{#374641}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
bashi
PTAL? Context: https://codereview.chromium.org/1658073002/diff/260001/third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp#newcode14
4 years, 10 months ago (2016-02-10 10:21:29 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-10 11:14:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686033002/1
4 years, 10 months ago (2016-02-10 11:14:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 11:33:56 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f0d33b6ebbdb33faf292e1e904064476f7f92b06 Cr-Commit-Position: refs/heads/master@{#374641}
4 years, 10 months ago (2016-02-10 11:34:52 UTC) #10
Yuki
4 years, 10 months ago (2016-02-10 13:29:44 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698