Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1686013002: generalize xferu64 procs using proc4f (Closed)

Created:
4 years, 10 months ago by reed2
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

generalize xferu64 procs using proc4f BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686013002

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -35 lines) Patch
M bench/XferU64Bench.cpp View 4 chunks +28 lines, -25 lines 0 comments Download
M gm/xferu64.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkXfermodeU64.cpp View 6 chunks +60 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686013002/1
4 years, 10 months ago (2016-02-10 03:56:48 UTC) #3
reed2
4 years, 10 months ago (2016-02-10 04:02:48 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 04:29:52 UTC) #7
mtklein
https://codereview.chromium.org/1686013002/diff/1/src/core/SkXfermodeU64.cpp File src/core/SkXfermodeU64.cpp (right): https://codereview.chromium.org/1686013002/diff/1/src/core/SkXfermodeU64.cpp#newcode87 src/core/SkXfermodeU64.cpp:87: template <DstType D> void src_u64_1(const SkXfermode::U64State& state, uint64_t dst[], ...
4 years, 10 months ago (2016-02-10 16:19:34 UTC) #8
reed1
4 years, 10 months ago (2016-02-10 19:34:24 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698