Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1685963004: Revert of Make SkPicture/SkImageGenerator default to SkCodec (Closed)

Created:
4 years, 10 months ago by kjlubick
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkPicture/SkImageGenerator default to SkCodec (patchset #7 id:120001 of https://codereview.chromium.org/1671193002/ ) Reason for revert: Breaks Ubuntu and Mac CMAKE Original issue's description: > Make SkPicture/SkImageGenerator default to SkCodec > > Remove reference to SkImageDecoder from SkPicture. Make the default > InstallPixelRefProc passed to CreateFromStream use > SkImageGenerator::NewFromEncoded instead. > > Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator. > Remove the old version that used SkImageDecoder. > > Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default > now behaves lazily. > > Update all clients to use the default. > > Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly. > > BUG=skia:4691 > BUG=skia:4290 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002 > > Committed: https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6 TBR=msarett@google.com,reed@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4691 Committed: https://skia.googlesource.com/skia/+/1de415f2c33febbac668500afbbb0c9b120c125f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -173 lines) Patch
M bench/ETCBitmapBench.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M dm/DMSrcSink.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/images.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 5 chunks +18 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -13 lines 0 comments Download
M public.bzl View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 2 chunks +0 lines, -99 lines 0 comments Download
M src/ports/SkImageGenerator_skia.cpp View 1 chunk +94 lines, -2 lines 0 comments Download
M tests/KtxTest.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M tests/PictureTest.cpp View 5 chunks +2 lines, -32 lines 0 comments Download
M tools/BUILD.public.expected View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/LazyDecodeBitmap.h View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/LazyDecodeBitmap.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
M tools/dump_record.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M tools/gpuveto.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tools/lua/lua_pictures.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/pinspect.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kjlubick
Created Revert of Make SkPicture/SkImageGenerator default to SkCodec
4 years, 10 months ago (2016-02-10 19:24:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685963004/1
4 years, 10 months ago (2016-02-10 19:25:01 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 19:25:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1de415f2c33febbac668500afbbb0c9b120c125f

Powered by Google App Engine
This is Rietveld 408576698