device/bluetooth/bluetooth_low_energy_device_mac.mm - Issue 1685963003: Adding the last test related with connect/disconnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_low_energy_device_mac.mm

Issue 1685963003: Adding the last test related with connect/disconnect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@connectdisconnect

Patch Set: Using FAILED instead of UNKNOWN error code Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_low_energy_device_mac.h ('k') | device/bluetooth/test/bluetooth_test_mac.h » ('j') | device/bluetooth/test/bluetooth_test_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_low_energy_device_mac.mm

diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.mm b/device/bluetooth/bluetooth_low_energy_device_mac.mm

index 4d6e3025e86e8c6af0e3f2cac30ff95178a75b9f..6658e8d84f83ab490081c54cc2d728f57e6edf1c 100644

--- a/device/bluetooth/bluetooth_low_energy_device_mac.mm

+++ b/device/bluetooth/bluetooth_low_energy_device_mac.mm

@@ -262,11 +262,13 @@ CBPeripheral* BluetoothLowEnergyDeviceMac::GetPeripheral() {

return peripheral_;

}

-void BluetoothLowEnergyDeviceMac::DidDisconnectPeripheral() {

+void BluetoothLowEnergyDeviceMac::DidDisconnectPeripheral(

+ BluetoothDevice::ConnectErrorCode error_code) {

if (create_gatt_connection_error_callbacks_.empty()) {

+ // TODO(http://crbug.com/585897): Need to pass the error.

DidDisconnectGatt();

} else {

- DidFailToConnectGatt(ERROR_FAILED);

+ DidFailToConnectGatt(error_code);

}