Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685953002: mojo: Now that mandoline/ is deleted, also remove mojo:clipboard. (Closed)

Created:
4 years, 10 months ago by Elliot Glaysher
Modified:
4 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Now that mandoline/ is deleted, also remove mojo:clipboard. This was only used from within mandoline. BUG=585637 Committed: https://crrev.com/fc221f4f4ec62224cdb5371c75d0e0802ac0e726 Cr-Commit-Position: refs/heads/master@{#374710}

Patch Set 1 #

Patch Set 2 : fix unmatched braces #

Patch Set 3 : Fix android build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -538 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/clipboard/BUILD.gn View 1 chunk +0 lines, -58 lines 0 comments Download
D components/clipboard/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/clipboard/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/clipboard/clipboard_application_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
D components/clipboard/clipboard_application_delegate.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D components/clipboard/clipboard_apptest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D components/clipboard/clipboard_standalone_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/clipboard/clipboard_standalone_impl.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D components/clipboard/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/clipboard/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/clipboard/public/interfaces/clipboard.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
M mojo/shell/standalone/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 10 months ago (2016-02-10 18:14:18 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 10 months ago (2016-02-10 18:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685953002/40001
4 years, 10 months ago (2016-02-10 18:54:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 20:17:31 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:43 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fc221f4f4ec62224cdb5371c75d0e0802ac0e726
Cr-Commit-Position: refs/heads/master@{#374710}

Powered by Google App Engine
This is Rietveld 408576698