Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: pkg/compiler/lib/src/cps_ir/builtin_operator.dart

Issue 1685893002: cpsir: insert guard and force specialization for [] and []= (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/builtin_operator.dart
diff --git a/pkg/compiler/lib/src/cps_ir/builtin_operator.dart b/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
index 2db4ac5bf62d70ee7a348e735609df5152f1abfd..a0daf1b9971f390703c5892e3c1e1597631e9c0e 100644
--- a/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
+++ b/pkg/compiler/lib/src/cps_ir/builtin_operator.dart
@@ -135,6 +135,13 @@ enum BuiltinOperator {
/// Compiles to `typeof x === 'number' && Math.floor(x) === x`
IsNumberAndFloor,
asgerf 2016/02/10 08:37:04 Please rename this to IsInteger to be consistent.
Siggi Cherem (dart-lang) 2016/02/12 00:14:00 Technically I no longer need IsNotInteger, so I co
asgerf 2016/02/12 10:29:10 No please leave it in. It's been bothering me that
+ /// Returns true if the argument is not an integer.
+ ///
+ /// The argument must be repeated 3 times.
+ ///
+ /// Compiles to `typeof x !== 'number' || Math.floor(x) !== x`
+ IsNotInteger,
+
/// Returns true if the argument is a fixed length Array.
///
/// Uses one argument.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698