Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 168583008: (Pre)Parser: Simplify NewExpression handling (fixed). (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

(Pre)Parser: Simplify NewExpression handling (fixed). Notes: - We use simple recursion to keep track of how many "new" operators we have seen and where. - This makes the self-baked stack class PositionStack in parser.cc unnecessary. - Now the logic is also unified between Parser and PreParser. - This is a fixed version of r19386. R=ulan@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19417

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : one more comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -144 lines) Patch
M src/parser.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/parser.cc View 1 2 5 chunks +51 lines, -96 lines 0 comments Download
M src/preparser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/preparser.cc View 1 3 chunks +38 lines, -42 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal of this fixed version. I commented here: https://codereview.chromium.org/166943002/ what the bug was.
6 years, 10 months ago (2014-02-17 15:12:04 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-17 15:22:58 UTC) #2
marja
6 years, 10 months ago (2014-02-17 15:41:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698