Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 168583006: Cleanup the double field tracking in Hydrogen. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Cleanup the double field tracking in Hydrogen. Use a dedicated BuildLoadNamedField() with PropertyAccessInfo, similar to BuildStoreNamedField() for optimized graph building, and a dedicated BuildLoadNamedField() for the code stubs, and don't depend on FLAG_track_double_fields during code generation. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -47 lines) Patch
M src/code-stubs-hydrogen.cc View 3 chunks +33 lines, -12 lines 0 comments Download
M src/hydrogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 10 months ago (2014-02-17 13:13:19 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-17 13:19:39 UTC) #2
Benedikt Meurer
6 years, 10 months ago (2014-02-17 13:23:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698