LayoutTests/fast/images/exif-orientation-height-image-document.html - Issue 168583003: Add a layout test for bug 320244

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/images/exif-orientation-height-image-document.html

Issue 168583003: Add a layout test for bug 320244 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!-- Test for http://crbug/320244 Image Document's displayed image has the wrong

	2 aspect ratio (the image looks stretched) for images with EXIF orientation. -->

	3 <script>

	4 if (window.testRunner)

	5 testRunner.queueLoad('resources/jpeg-height-exif-orientation.jpg?' + Math.ra ndom());
	pdr. 2014/02/18 02:59:18 Math.random() shouldn't be required here. Can you Math.random() shouldn't be required here. Can you use an existing image that's smaller (such as resources/exif-orientation-1-ul.jpg)? This will perform better on the slow debug bots, and will not make future reviewers hungry. Noel Gordon 2014/02/18 03:32:02 Lemme remove random() ... Show quoted text On 2014/02/18 02:59:18, pdr wrote: > Math.random() shouldn't be required here. Lemme remove random() ... Show quoted text > Can you use an existing image that's smaller (such as > resources/exif-orientation-1-ul.jpg)? This will perform better on the slow debug > bots, and will not make future reviewers hungry. Yeah sorry for the large image, but smaller images don't reproduce the bug if I recall correctly.
	6 else

	7 document.write('This test requires TestRunner.');

	8 </script>

OLD	NEW