Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 16858013: Notify CPU profiler when calling native getters (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
Reviewers:
dcarney, Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Notify CPU profiler when calling native getters This change modifies code produced by BaseLoadStubCompiler::GenerateLoadCallback so that instead of calling AccessorGetter direcly it calls InvokeAccessorGetter which changes VM state and calls the actual callback. This way CPU profiler knows which external callback is being executed in this case. Indirect call happens only if CpuProfiler::is_profiling() is true. This is exactly same change as r15116 with a build fix for test-api.cc BUG=244580 TBR=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -136 lines) Patch
M src/api.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +24 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +63 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +29 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +19 lines, -1 line 0 comments Download
M src/cpu-profiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +26 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +55 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 4 chunks +32 lines, -1 line 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 26 chunks +180 lines, -96 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yurys
7 years, 6 months ago (2013-06-13 19:16:57 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r15135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698