Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 16858003: MIPS: Separate Cell and PropertyCell spaces (Closed)

Created:
7 years, 6 months ago by palfia
Modified:
7 years, 6 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Separate Cell and PropertyCell spaces Port r15089 (5c28e4e7) Original commit message: This makes it possible to store additional information on property cells, for example Type and optimized Code dependencies. BUG= Committed: https://code.google.com/p/v8/source/detail?r=15103

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -74 lines) Patch
M src/mips/assembler-mips-inl.h View 3 chunks +13 lines, -15 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 8 chunks +13 lines, -14 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 13 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
7 years, 6 months ago (2013-06-12 22:56:27 UTC) #1
Paul Lind
LGTM. Please fix the nit before submitting. https://codereview.chromium.org/16858003/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/16858003/diff/1/src/mips/code-stubs-mips.cc#newcode7784 src/mips/code-stubs-mips.cc:7784: __ Assert(eq, ...
7 years, 6 months ago (2013-06-12 23:21:59 UTC) #2
palfia
Fixed nits. https://codereview.chromium.org/16858003/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/16858003/diff/1/src/mips/code-stubs-mips.cc#newcode7784 src/mips/code-stubs-mips.cc:7784: __ Assert(eq, "Expected property cell in register ...
7 years, 6 months ago (2013-06-12 23:37:26 UTC) #3
palfia
7 years, 6 months ago (2013-06-12 23:39:34 UTC) #4
Message was sent while issue was closed.
Committed manually as r15103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698