Enable coredumps for dart2js unit tests on buildbot.

tools/bots/compiler.py

 #!/usr/bin/python
 
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """
 Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
 
 import os
 import platform
 import re
 import shutil
 import socket
 import string
 import subprocess
 import sys
 
 import bot
+import bot_utils
 
 DARTIUM_BUILDER = r'none-dartium-(linux|mac|windows)'
 DART2JS_BUILDER = (
     r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?(-(x64))?(-(cps))?-?(\d*)-?(\d*)')
 DART2JS_FULL_BUILDER = r'full-(linux|mac|win7|win8)(-(ie10|ie11))?(-checked)?(-minified)?-(\d+)-(\d+)'
 WEB_BUILDER = (
     r'dart2js-(ie9|ie10|ie11|ff|safari|chrome|chromeOnAndroid|safarimobilesim|opera|drt)-(win7|win8|mac10\.7|mac10\.8|mac10\.9|linux)(-(all|html))?(-(csp))?(-(\d+)-(\d+))?')
 
 IE_VERSIONS = ['ie10', 'ie11']
 
@@ skipping 244 matching lines @@
       pass
 
   unit_test_flags = [flag for flag in flags if flag.startswith('--shard')]
   # Run the unit tests in checked mode (the VM's checked mode).
   unit_test_flags.append('--checked')
   unit_test_flags.append('--vm-options=--abort-on-assertion-errors')
   if runtime == 'd8':
     # The dart2js compiler isn't self-hosted (yet) so we run its
     # unit tests on the VM. We avoid doing this on the builders
     # that run the browser tests to cut down on the cycle time.
-    TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'],
-             unit_test_flags, arch)
+    with bot_utils.CoredumpEnabler():
+      TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js', 'try'],
+               unit_test_flags, arch)

[kustermann, 2016/02/11 13:45:19]

Is it intentionally only for 'd8' runtime?

 
   if compiler == 'dart2js' and runtime == 'drt':
     # Ensure that we run the "try" tests on Content Shell.
     TestStep("incremental_compilation", mode, system, 'none', runtime,
              ['try'], unit_test_flags, arch)
 
   if compiler == 'dart2js' and runtime in ['ie10', 'ie11']:
     TestStep(compiler, mode, system, compiler, runtime,
              ['html', 'pkg', 'samples', 'co19'], flags, arch)
   else:
@@ skipping 114 matching lines @@
     if build_info.mode == 'debug':
       target = 'dart2js_bot_debug'
     args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
             '--arch=' + build_info.arch, target]
     print 'Build SDK and d8: %s' % (' '.join(args))
     bot.RunProcess(args)
 
 
 if __name__ == '__main__':
   bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)