Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Unified Diff: media/capture/video/fake_video_capture_device_unittest.cc

Issue 1685713003: Remove V4L2CaptureDelegate{Single,Multi}Plane, VCD::Client::OnIncomingCapturedYuvData() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: perkj@ comments and reverted change to WeakPtr Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/fake_video_capture_device_unittest.cc
diff --git a/media/capture/video/fake_video_capture_device_unittest.cc b/media/capture/video/fake_video_capture_device_unittest.cc
index f61b0858aa791398dd9a608710de0a8bdcbbd3d6..eff85fc41e18f9191f4d3e1243d913ee44a85eb2 100644
--- a/media/capture/video/fake_video_capture_device_unittest.cc
+++ b/media/capture/video/fake_video_capture_device_unittest.cc
@@ -75,18 +75,6 @@ class MockClient : public VideoCaptureDevice::Client {
const base::TimeTicks& timestamp) {
frame_cb_.Run(format);
}
- void OnIncomingCapturedYuvData(const uint8_t* y_data,
- const uint8_t* u_data,
- const uint8_t* v_data,
- size_t y_stride,
- size_t u_stride,
- size_t v_stride,
- const VideoCaptureFormat& frame_format,
- int clockwise_rotation,
- const base::TimeTicks& timestamp) {
- frame_cb_.Run(frame_format);
- }
-
// Virtual methods for capturing using Client's Buffers.
scoped_ptr<Buffer> ReserveOutputBuffer(const gfx::Size& dimensions,
media::VideoPixelFormat format,
@@ -187,9 +175,7 @@ class FakeVideoCaptureDeviceBase : public ::testing::Test {
class FakeVideoCaptureDeviceTest
: public FakeVideoCaptureDeviceBase,
public ::testing::WithParamInterface<
- ::testing::tuple<FakeVideoCaptureDevice::BufferOwnership,
- FakeVideoCaptureDevice::BufferPlanarity,
- float>> {};
+ ::testing::tuple<FakeVideoCaptureDevice::BufferOwnership, float>> {};
struct CommandLineTestData {
// Command line argument
@@ -207,19 +193,18 @@ TEST_P(FakeVideoCaptureDeviceTest, CaptureUsing) {
ASSERT_FALSE(names->empty());
scoped_ptr<VideoCaptureDevice> device(new FakeVideoCaptureDevice(
- testing::get<0>(GetParam()), testing::get<1>(GetParam()),
- testing::get<2>(GetParam())));
+ testing::get<0>(GetParam()), testing::get<1>(GetParam())));
ASSERT_TRUE(device);
VideoCaptureParams capture_params;
capture_params.requested_format.frame_size.SetSize(640, 480);
- capture_params.requested_format.frame_rate = testing::get<2>(GetParam());
+ capture_params.requested_format.frame_rate = testing::get<1>(GetParam());
device->AllocateAndStart(capture_params, std::move(client_));
WaitForCapturedFrame();
EXPECT_EQ(last_format().frame_size.width(), 640);
EXPECT_EQ(last_format().frame_size.height(), 480);
- EXPECT_EQ(last_format().frame_rate, testing::get<2>(GetParam()));
+ EXPECT_EQ(last_format().frame_rate, testing::get<1>(GetParam()));
device->StopAndDeAllocate();
}
@@ -228,8 +213,6 @@ INSTANTIATE_TEST_CASE_P(
FakeVideoCaptureDeviceTest,
Combine(Values(FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS,
FakeVideoCaptureDevice::BufferOwnership::CLIENT_BUFFERS),
- Values(FakeVideoCaptureDevice::BufferPlanarity::PACKED,
- FakeVideoCaptureDevice::BufferPlanarity::TRIPLANAR),
Values(20, 29.97, 30, 50, 60)));
TEST_F(FakeVideoCaptureDeviceTest, GetDeviceSupportedFormats) {
« no previous file with comments | « media/capture/video/fake_video_capture_device_factory.cc ('k') | media/capture/video/linux/v4l2_capture_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698