media/capture/video/linux/video_capture_device_linux.h - Issue 1685713003: Remove V4L2CaptureDelegate{Single,Multi}Plane, VCD::Client::OnIncomingCapturedYuvData()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/linux/video_capture_device_linux.h

Issue 1685713003: Remove V4L2CaptureDelegate{Single,Multi}Plane, VCD::Client::OnIncomingCapturedYuvData() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase -- hubbe@ added more VideoPixelFormats Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/capture/video/linux/v4l2_capture_delegate.cc ('K') | « media/capture/video/linux/video_capture_device_factory_linux.cc ('k') | media/capture/video/linux/video_capture_device_linux.cc » ('j') | media/capture/video/linux/video_capture_device_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/video/linux/video_capture_device_linux.h

diff --git a/media/capture/video/linux/video_capture_device_linux.h b/media/capture/video/linux/video_capture_device_linux.h

index 0f654db55e8f0b92e52520588de389e43725c754..45cad6676fcb51c8e85fbde5b2e74735e876b9eb 100644

--- a/media/capture/video/linux/video_capture_device_linux.h

+++ b/media/capture/video/linux/video_capture_device_linux.h

@@ -48,7 +48,8 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {

// Internal delegate doing the actual capture setting, buffer allocation and

// circulation with the V4L2 API. Created and deleted in the thread where

// VideoCaptureDeviceLinux lives but otherwise operating on |v4l2_thread_|.

- scoped_refptr<V4L2CaptureDelegate> capture_impl_;

+ // Weak.

+ V4L2CaptureDelegate* capture_impl_;

perkj_chrome 2016/02/12 11:01:40 this looks like a memory leak. Should be scoped_pt

mcasas 2016/02/12 21:32:43 Acknowledged.

base::Thread v4l2_thread_; // Thread used for reading data from the device.