Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 16857004: MIPS: Increase sanity of integer division handling. (Closed)

Created:
7 years, 6 months ago by kilvadyb
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Increase sanity of integer division handling. Port r15057 (c82c777) Original commit message: - In the INT32 BinaryOpStub, fix type feedback collection for DIV, bringing it in line with other platforms. - In Lithium codegen, emit proper inlined code, don't call the stub. - Drive-by fix: assert appropriate CpuFeaturesScope for SDIV. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -37 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +17 lines, -28 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 6 months ago (2013-06-13 14:53:22 UTC) #1
Paul Lind
LGTM.
7 years, 6 months ago (2013-06-13 16:23:19 UTC) #2
palfia
7 years, 6 months ago (2013-06-13 16:45:35 UTC) #3
Committed as r15127.

Powered by Google App Engine
This is Rietveld 408576698