Chrome URL bugfix + added tests for chrome_app.apis.

src/chrome_app/apis.py

 #!/usr/bin/env python2
 # -*- coding: utf-8 -*-
 
 # Copyright 2015 Google Inc. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
@@ skipping 24 matching lines @@
 import os
 import sys
 
 import manifest as app_manifest
 import surrogateescape
 import walk
 
 # Regular expression matching Chrome API namespaces, e.g. chrome.tts and
 # chrome.app.window.
 CHROME_API_REGEX = re.compile(
-    r'(?<![\w.])chrome\.((?:(?:app|sockets|system)\.)?\w+)')
+    r'(?<![\w.])chrome\.(?!google)((?:(?:app|sockets|system)\.)?\w+)')
 
 # Regular expression matching Chrome apps API usage, e.g.
 # chrome.tts.speak and chrome.app.runtime.onLaunched.addListener.
-CHROME_API_USAGE_REGEX = re.compile(r'(?<![\w.])chrome\.((?:\w+\.)+\w+)')
+CHROME_API_USAGE_REGEX = re.compile(
+    r'(?<![\w.])chrome\.(?!google)((?:\w+\.)+\w+)')
 
 # Regular expression matching anything in the chrome namespace, e.g. chrome.tts
 # or chrome.app.runtime.onLaunched.addListener.
-CHROME_NAMESPACE_REGEX = re.compile(r'chrome((?:\.\w+)+)')
+CHROME_NAMESPACE_REGEX = re.compile(r'chrome((?:\.(?!google)\w+)+)')
 
 # Regular expression matching both the API and the member, assuming both exist.
 CHROME_API_AND_MEMBER_REGEX = re.compile(r"""
   (?<![\w.])chrome\. # In the chrome namespace
+  (?!google) # chrome.google is not an API

[Matt Giuca, 2016/02/11 02:17:12]

Mmmmmm... I don't like this. As you said in the CL description, this is only
going to catch chrome.google.com, and not any other web domain with chrome in
it.

You also say "hardcoding a list of APIs is a bad idea". Why? The set of APIs is
fixed whereas the set of domains with "chrome" as a subdomain is limitless. So I
think we should hardcode the APIs. (But not in the regex; that would be a
nightmare. Instead, after you apply the regex, check to see if the API name
you've captured is in the list.)

Also: I don't think adding "(?!google)" to this regex is correct. It means
you're going to have potentially weird parses; if you encounter a domain like
"chrome.googlex.com" then you will return "x" as the API name.

   ( # Capture the full API name
     (?:(?:app|sockets|system)\.)? # API may be part of a super-API namespace
     \w+ # Actual API name
   )
   \.
   ( # Capture the full member name
     (?:\w+\.?)+
   )
 """, re.VERBOSE)
 
@@ skipping 137 matching lines @@
     info = apps_apis(args.directory)
     for name, path, apis in info:
       print("{} ({}): {}".format(name, path, ", ".join(apis)))
   else:
     apis = app_apis(args.directory)
     print(", ".join(apis))
 
 
 if __name__ == '__main__':
   sys.exit(main())